set default extPlugin path to relative path. #5632
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu199195
reviewed
Aug 28, 2024
| @@ -30,7 +30,7 @@ public final class ShenyuPluginPathBuilder { | |||
|
|
|||
| private static final String PLUGIN_PATH = "plugin-ext"; | |||
|
|
|||
| private static final String DEFAULT_EXT_PLUGIN_PATH = "/ext-lib/"; | |||
| private static final String DEFAULT_EXT_PLUGIN_PATH = "ext-lib/"; | |||
There was a problem hiding this comment.
Why can't use '/ ' at the beginning?
There was a problem hiding this comment.
The absolute path of /ext-lib/ is not in the deployment directory. On Linux, it's just pointing to the /ext-lib folder. On Windows it is in the root of the deployment driver. A log point added to confirm this. We can find this in test case too:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default value of extPlugin path
/ext-lib/is not consistent with described in deployment document，which resulting custom plugin jars auto loading failed. On Windows, bootstrap binary package's startup context isbindirectory, ext plugin relative path is not correct too.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.